Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more icons and animations #39

Open
mbr-sn opened this issue Jun 25, 2023 · 5 comments
Open

Add more icons and animations #39

mbr-sn opened this issue Jun 25, 2023 · 5 comments

Comments

@mbr-sn
Copy link

mbr-sn commented Jun 25, 2023

Can we add some more icons and animations to the gfx folder?
Attached is one I created, feel free to add it to the code, share and enjoy.
python3 ./led-badge-11x44.py -s4 -m5 :gfx/animated_alien_48x11.png:

animated_alien_48x11

@s-light
Copy link
Collaborator

s-light commented Jun 29, 2023

if you open a pull-request and ensure the icon is drawn by yourself i think we can merge this.
@jnweiger any doubts?

@jnweiger
Copy link
Owner

That is a nice one!
Yes, as @s-light says, the only 'obstacle' is copyright and licensing.
We need to know if you created this yourself, or from where it came, and under which license we would be able to use it.
If it's your own design, any you don't have any specific requirments, I suggest that you pick the same license that we use for the rest of this project, GPLv2:
https://github.com/jnweiger/led-name-badge-ls32/blob/master/LICENSE

@mbr-sn
Copy link
Author

mbr-sn commented Jun 30, 2023

It is obviously inspired by old arcade games, but I drew it myself from scratch pixel by pixel, so I guess copyright is not an issue (ianal though). Permission is hereby granted with the same license as the rest of the code, GPLv2. :-)

It took me a while to figure out that it actually needs an image with 48x11 pixel frames, even though my display is 44x11. But one must not use the rightmost 4 columns, otherwise they "wrap around" to the left side of the display, it's a bit confusing at first. So I thought sharing an example would be nice for demo purposes.

Image Magick is a useful tool by the way to split and merge the frames.

@ManInDark
Copy link

It took me a while to figure out that it actually needs an image with 48x11 pixel frames, even though my display is 44x11

I'd appreciate if that were to be mentioned in the README, as this is crucial information.

@jnweiger
Copy link
Owner

jnweiger commented Oct 1, 2023

It took me a while to figure out that it actually needs an image with 48x11 pixel frames, even though my display is 44x11

I'd appreciate if that were to be mentioned in the README, as this is crucial information.

Animations weren't mentioned in the README add all. Added b23c84a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants