-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency injection support #17
Comments
I think this only makes sense if we pair it with mandatory XSD Schemas and XSLT support. |
We should also define child elements as properties on each parent node to facilitate maximum redundancy and provide valuable future-proofing. <field copyright="This field is property of ACME™ studios 2018." name="maxNuts" type="Money" value="30" >
<copyright value="This field is property of ACME™ studios 2018.">
This field is property of ACME™ studios 2018.
</copyright>
<name value="maxNuts">
maxNuts
</name>
<type value="Money">
Money
</type>
<value value="30">
30
</value>
</field> |
XSD? Sure. XSLT? The readme says:
So obviously one should want to concat XML strings instead. |
I like the cut of your jib! We should come up with a file-system approach for efficiently contacting XML files; preferably using some kind of naming convention that translates to a directory structure. |
First comment: |
The XML example needs more namespace |
Dependency injection is necessary for the flexibility required of enterprise grade software. Consider the example from the readme:
This is not very flexible - what if customers want to add more values? Or change existing ones? They will have to change the constructor's signature and calls!
I suggest replacing all constructor arguments with dependency injection:
The dependencies themselves could elegantly be written in XML config files:
This is a much cleaner approach than argument passing - modern languages should definitely use it!
The text was updated successfully, but these errors were encountered: