Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut: 'Show & Focus/Hide Sidenav' not working as expected #3084

Closed
AngeloThys opened this issue Mar 17, 2024 · 3 comments
Closed

Shortcut: 'Show & Focus/Hide Sidenav' not working as expected #3084

AngeloThys opened this issue Mar 17, 2024 · 3 comments

Comments

@AngeloThys
Copy link

AngeloThys commented Mar 17, 2024

Your Environment

Expected Behavior

When pressing the related keybinding when:

A. Sidenav is not shown

Show and focus the sidenav.

B. Sidenav is shown

Hide the sidenav.

Current Behavior

Sidenav is always shown.
When the keybind is used, sidenav gains focus.
It does not hide the sidenav on second use.

Steps to Reproduce (for bugs)

  1. Activate keybinding.
  2. Focus sidenav.
  3. Activate keybinding.
  4. Nothing happens.

Can you reproduce this reliably?

Yes. It happens consistently.

Console Output

image

The first 2 [layout] outputs in the console are executed with the console closed, whilst the remaining are executed with the console open. See edge case

Error Log (Desktop only)

Not provided.

Edge case (?)

When performing the same steps with the console open (shift+ctrl+i), the keybinding for the shortcut: 'Show & Focus/Hide Sidenav' works as expected.

@AngeloThys AngeloThys added the bug label Mar 17, 2024
Copy link

Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding!

@johannesjo
Copy link
Owner

Hey there! When the app window is very wide the navigation is always shown.

@Jagdfalke Jagdfalke removed the bug label Mar 28, 2024
@AngeloThys
Copy link
Author

@johannesjo so it has to do with the screen being smaller when the console is open rather than an actual bug.
Good to know! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants