Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the Post ID for the Post Meta results #175

Open
cliffordp opened this issue Jan 5, 2024 · 10 comments
Open

Show the Post ID for the Post Meta results #175

cliffordp opened this issue Jan 5, 2024 · 10 comments

Comments

@cliffordp
Copy link

First time using the plugin, tyvm for it.

Please provide the Post information (Post ID with edit/view links) even for the Post Meta results:
image

P.S.
2) Shouldn't the Row# be without a comma, in case I want to copy it?
3) Please make it more obvious that clicking on the result will perform the replacement, not just if I hover over it for a while to view the <title>. It'd be nice if there was a Read Only view/toggle so I don't do accidental clicks.

@johngodley
Copy link
Owner

Clicking on the result doesn't immediately perform the replacement.

@cliffordp
Copy link
Author

meaning it does eventually?

@johngodley
Copy link
Owner

Yes. Have you pressed it?

@cliffordp
Copy link
Author

No, just was looking for Replace All.
FYI: it was not obvious it was only going to replace the page size (25 quantity) and not actually all

@johngodley
Copy link
Owner

It does replace all and not just the page size. Are we still talking about the same thing?

@cliffordp
Copy link
Author

OK, I tried the single click on orange and that's nice! maybe the <title> should change from "Click to replace match" to "Click to replace manually"

I found it odd, though, that clicking on it does not prompt me with the global replacement (my shortcode in this example) but instead reverts it back to the original:
image

And when I tried replacing it solo (orange) it gave an error:

Plugin: 3.0.8
WordPress: 6.4.2 (single)
PHP: 7.4.33 256M 300s
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36
JavaScript: /wp-content/plugins/search-regex/search-regex.js
REST API: /wp-json/
Query: ?page=search-regex.php&preset=6599900cf12d8

Error: No matching row (rest_invalid_param)
Raw: {"code":"rest_invalid_param","message":"No matching row","data":{"status":400}}

So I refreshed the page, performed the same search, then used Replace All and that worked.

@johngodley
Copy link
Owner

If you want to replace globally then you use the 'replace all' button. Details about using the plugin can be found here:

https://searchregex.com/

@cliffordp
Copy link
Author

Am I understanding correctly that you don't want me to continue reporting bugs and UX improvements?

FYI: here's the Replace All doing not all but also not just 25
2024-01-06 SearchRegex Replace All not quite

@johngodley
Copy link
Owner

Am I understanding correctly that you don't want me to continue reporting bugs and UX improvements?

I don't believe I've said that.

You have reported things before trying to use them, and it is hard to know what you are currently referring to.

I am struggling to make out what you are showing in the gif.

@cliffordp
Copy link
Author

OK, thanks for clarifying. In the gif it shows clicking Replace All when the pagination is 25. It shows 25 rows then it all of a sudden says 152 rows, even though the initial result count was 191 rows. Upon completing the first Replace All, there are 39 rows still found upon performing the same search.

For clicking the orange, why wouldn't it pre-fill my replacement value instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants