Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CMAKE_TOOLCHAIN_FILE with CMAKE_PROJECT_INCLUDE_BEFORE #990

Open
johnmcfarlane opened this issue Dec 30, 2021 · 4 comments
Open
Labels
exploratory request Request for a new feature to be added to CNL

Comments

@johnmcfarlane
Copy link
Owner

johnmcfarlane commented Dec 30, 2021

Hypothesis: CMake toolchain files are not the right place to customise the build; they are for configuring toolchains only. There are other, more appropriate ways to vary builds in the way that the workflows require.

Test this hypothesis by replacing the toolchain files with something more suitable. Setting one of the PROJECT_INCLUDE variables seems like one possible avenue of exploration.

Acceptance criteria: the end result is that the pipeline runs as it does currently, but with little or no reliance on CMake toolchain files.

@johnmcfarlane johnmcfarlane added the request Request for a new feature to be added to CNL label Dec 30, 2021
@phyBrackets
Copy link

you mean CONAN_CMAKE_TOOLCHAIN_FILE to CONAN_CMAKE_PROJECT_INCLUDE_BEFORE right?

@johnmcfarlane
Copy link
Owner Author

johnmcfarlane commented Jan 17, 2022 via email

@phyBrackets
Copy link

So , if i tried to make these specific changes , then how can i test that they work fine ? before commit the changes.

@johnmcfarlane
Copy link
Owner Author

@phyBrackets description updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exploratory request Request for a new feature to be added to CNL
Projects
None yet
Development

No branches or pull requests

2 participants