Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost buttons active bg-color are not transparent #26

Open
jonasbirkelof opened this issue Feb 24, 2023 · 0 comments
Open

Ghost buttons active bg-color are not transparent #26

jonasbirkelof opened this issue Feb 24, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jonasbirkelof
Copy link
Owner

When a ghost button (.btn-ghost-*) has the active state, tha background color is using the tint-color() mixin to give it a lighter golor than the theme color. This works on light/white backgrounds but on darker backgrounds it is just to bright.

The active background color should be transparent just like the hover background color.

I will make a PR with this change, but the quick fick for the source files is to change:

@mixin button-ghost-variant(
   $bg-color-active: tint-color($theme-color, 85%),
) {

to...

@mixin button-ghost-variant(
   $bg-color-active: #{$theme-color}2a,
) {

...in the file mixins\_bcss-buttons.scss.

@jonasbirkelof jonasbirkelof added the bug Something isn't working label Feb 24, 2023
@jonasbirkelof jonasbirkelof self-assigned this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant