-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiword token range sometimes being saved as HEAD #475
Comments
Could you post an example sentence or screenshot that breaks like this? |
Now my setup is borked and I can't get the viewer to work for any sentence even with a new upload. :( But here is the sentence that was giving me grief:
Somehow token 2 was becoming unattached and token 24 was showing up with |
The viewer is not working anymore in Firefox but I'm able to view and download it in Chrome just fine. And it downloads the correct parse. Do I need to clear my Firefox cache or something? |
And it works in Firefox Private Browsing mode, so something got messed up in my browser session. |
Not sure. In a new browser session I can't reproduce. Must have something to do with corrupted local storage or whatever in my original session. |
Oh but this is interesting: if I click the third word and enter "c" to merge left, it deletes the first word. So the merging functionality must be buggy. |
Another bug: if you initialize the tree without the multiword token, click the 2nd word and merge left, it concatenates the words in the wrong order:
|
This should check the indices to see which token is first (combining two tokens into a multiword token/supertoken): ud-annotatrix/notatrix/src/nx/sentence.js Line 381 in e951f72
also here (merging two tokens into one regular token): ud-annotatrix/notatrix/src/nx/sentence.js Line 324 in e951f72
|
Oops, I didn't mean to close the whole issue ... but a3828a4 should fix this part:
Thanks for the hint 😁 |
|
Thanks, pulled the update. Now I find that if I create several multiword tokens and then select one of them to split ("s"), it may split the wrong one. |
For words in a multiword token, when I export (download) a .conllu file, sometimes their dependents have the entire MWT in the HEAD column, e.g.
1-2
instead of1
. This breaks the viewer when I reopen the sentence.The text was updated successfully, but these errors were encountered: