Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when two nodes clicked in existing graph, new deprel is created overwriting existing one #502

Open
jonorthwash opened this issue Jul 20, 2022 · 1 comment

Comments

@jonorthwash
Copy link
Owner

When two nodes are clicked on the graph to create a deprel, a new deprel is created which overwrites any existing one. This results in data loss.

Perhaps it should just do nothing? It could either stay in "need to select 2nd node" mode, or return to "looking at the graph (and not editing deprels)" mode.

@nschneid
Copy link

Or it could request confirmation with a modal dialog ("Overwrite existing deprel?"), though that could get annoying.

Honestly the current behavior might be fine as long as it's visually salient that an old deprel is disappearing, and the undo button is available to recover if it was accidental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants