Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path filter does not allow dots at the beginning of folders / files names #48

Open
n3t opened this issue Apr 16, 2021 · 1 comment
Open

Comments

@n3t
Copy link

n3t commented Apr 16, 2021

Paths with dots at the beginning of folder or file name doesn't pass current path filter regular expressions. For example /var/www/.secret doesn't pass, even it is valid path. This influence Joomla CMS update system, when used such path for global temp dir.

Steps to reproduce the issue

Set in Joomla global configuration Temp path with hidden folder (starting with dot), for example /var/www/.tmp.
Go to Joomla update component and try to download and install update.

Expected result

No error, update is installed.

Actual result

Error is displayed, update is not installed.

System information (as much as possible)

Joomla CMS with Joomla Filter 1.4.3

Additional comments

This is B/C break in Joomla CMS, as it influence Joomla update system. Path doesn't pass filter, so returns empty string, which causes updater to fail download update file, with incorrect error message.

Tried to solve it in joomla/joomla-cms#33151, which was incorrect, as I was noticed of double dots folders (and also PR to wrong project :))

@n3t
Copy link
Author

n3t commented Jun 29, 2021

No comment on this? Currently this issue makes one of my websites unupdateable. The web root path contains @, which causes Joomla updater to fail. No way to influence this, this is hosting settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant