Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

failed user login is not handled correctly #262

Closed
karenetheridge opened this issue Sep 24, 2020 · 3 comments
Closed

failed user login is not handled correctly #262

karenetheridge opened this issue Sep 24, 2020 · 3 comments
Assignees
@dustinryerson
Labels
bug Something isn't working wat Causes operator confusion

Comments

@karenetheridge
Copy link
Contributor

As discussed in MM last week -- when the user enters an invalid password at the login page, the 401 response is being sent back to the browser which kicks up a default user auth form.

Screen Shot 2020-09-24 at 2 37 41 PM
@karenetheridge karenetheridge added bug Something isn't working wat Causes operator confusion labels Sep 24, 2020
@dustinryerson
Copy link
Contributor

This is being caused by the WWW-Authenticate header being returned in the response, which was added to the API here: joyent/conch-api#985

karenetheridge added a commit to joyent/conch-api that referenced this issue Oct 13, 2020
@karenetheridge
fix authentication challenge returned on 401, 403 responses
f719979 
We should not be sending "Basic" as we do not recognize that type, but rather "Bearer" where the
Authorization header is expected to contain a JWT.

see joyent/conch-ui#262 (comment)
@karenetheridge karenetheridge mentioned this issue Oct 13, 2020
Merged
@karenetheridge
Copy link
Contributor Author

I still think it's odd that the response (and its headers) is being seen by the browser rather than being captured by the js that made the request. The API does not structure its responses with the browser in mind.

@dustinryerson
Copy link
Contributor

This issue has been resolved by joyent/conch-api#1042.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dustinryerson dustinryerson

Labels
bug Something isn't working wat Causes operator confusion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karenetheridge @dustinryerson