Skip to content
This repository has been archived by the owner on Dec 31, 2019. It is now read-only.

grr could check current patchset parent #12

Open
jlevon opened this issue Apr 9, 2019 · 1 comment
Open

grr could check current patchset parent #12

jlevon opened this issue Apr 9, 2019 · 1 comment

Comments

@jlevon
Copy link

jlevon commented Apr 9, 2019

As seen in https://cr.joyent.us/#/c/6010/

I think what happened here is that patchset 2 had a parent 1df0262127ba10f20347daae7ac94c0d44fcd150

Then I rebased in Gerrit, and ran grr again. Because this then
rebased back to a previous parent, and modified the commit message,
I lost my CRs.

It would be great if grr could notice that the current patchsets parent is different
(an ancestor?) of the current local one, and refuse to upload by default.
trentm pushed a commit that referenced this issue Jul 31, 2019
@trentm
support for multiple issues (#12)
40bff97
trentm added a commit that referenced this issue Jul 31, 2019
@trentm
some tweaks to multiple issue support (#12)
12e990e 
- rename the long opts to '--{add,remove}-issues'
- use dashdash custom type to parse user-supplied value sooner
- clean up (debatable I suppose :) the option/arg handling to determine
  the action being performed
- drop unused optional "ISSUE" arg to `grr -D [ISSUE]`
- allow extra issues initially via `grr MAIN-ISSUE [EXTRA-ISSUES ...]`
- show titles of extra issues in regular grr output
- cache issue data for extra issues in .git/config (and add a TODO for
  how these can be used to not have to re-fetch extra issue data for
  every run)
@trentm
Copy link
Contributor

trentm commented Jul 31, 2019

^^ I accidentally referred to issue #12 (this one) instead of issue #13 in those commits.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trentm @jlevon