Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Rack Layout and Assignment handling needs thought #35

Open
perigrin opened this issue Dec 10, 2019 · 3 comments
Open

Rack Layout and Assignment handling needs thought #35

perigrin opened this issue Dec 10, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request high priority These issues should take preference v3 Applies to V3 work

Comments

@perigrin
Copy link
Contributor

When you' re in the middle of a build you're not really thinking about things at the global level and you maybe just need to add a rack layout slot to a single rack.

The rack layout should be easy to adjust from within the rack [ID] command tree.

@perigrin perigrin added the enhancement New feature or request label Dec 10, 2019
@karenetheridge
Copy link
Contributor

karenetheridge commented Dec 11, 2019

Note: these endpoints don't currently exist, but are fairly simple to add:

POST /room/:room_id_or_alias/rack/:rack_id_or_name/layout
POST /rack/:rack_id_or_full_name/layout

e.g. POST /room/iad103/rack/0104/layout, POST /rack/DC12:1F:211250:0102/layout

CORRECTION -- these endpoints do exist... this is Conch::Controller::Rack::overwrite_layouts (all layouts not present in the incoming payload for the target rack are removed). Perhaps some revisions are needed to fit the needs of the clients.

@karenetheridge
Copy link
Contributor

I am leaning towards moving the existing POST /room/iad103/rack/0104/layout endpoint (which overwrites all existing layouts in the rack with the incoming payload) to the PUT method, which leaves POST open to implement "create a new layout in this rack, without touching the other layouts".

@karenetheridge
Copy link
Contributor

see also joyent/conch-api#966

@perigrin perigrin added the v3 Applies to V3 work label Jan 9, 2020
@perigrin perigrin self-assigned this Jan 9, 2020
@perigrin perigrin added the high priority These issues should take preference label Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request high priority These issues should take preference v3 Applies to V3 work
Projects
None yet
Development

No branches or pull requests

2 participants