Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping kit import doesn't clear temporary files #723

Closed
shivay-couchbase opened this issue Jan 24, 2025 · 3 comments
Closed

Stopping kit import doesn't clear temporary files #723

shivay-couchbase opened this issue Jan 24, 2025 · 3 comments
Labels
wontfix This will not be worked on

Comments

@shivay-couchbase
Copy link

At the moment if you stop a kit import command in progress, the temporary files don't get automatically deleted. There should be an indicator for users to delete the temporary file being created.

@shivay-couchbase shivay-couchbase added the enhancement New feature or request label Jan 24, 2025
@shivay-couchbase
Copy link
Author

Image

@amisevsk
Copy link
Contributor

Currently, kit does not try to handle signals (pressing ctrl+c will sent SIGINT to the process), so when it encounters the signal it exits immediately. This prevents both doing any cleanup of files locally, but also printing any messages suggesting you should clean up manually.

We can catch and ignore signals, but I'm not sure it's a standard thing to do -- it could be annoying to have kit not exit immediately on SIGINT.

For what it's worth, we use temporary directories on all OSes for this process, so those files would be automatically deleted on restart.

@bmicklea bmicklea changed the title At the moment if you stop a kit import command in progress, the temporary files don't get automatically deleted. There should be an indicator for users to delete the temporary file being created. Stopping kit import doesn't clear temporary files Feb 3, 2025
@bmicklea bmicklea added wontfix This will not be worked on and removed enhancement New feature or request labels Feb 3, 2025
@bmicklea
Copy link
Contributor

bmicklea commented Feb 3, 2025

Closing this as won't fix since the solution to fix it is potentially more cumbersome and annoying for users than the current situation. Because these files get cleaned up on restart the severity of the issue isn't very high.

@bmicklea bmicklea closed this as completed Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants