Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquote: remove quotation marks #1024

Open
aneziac opened this issue Feb 24, 2025 · 1 comment
Open

Blockquote: remove quotation marks #1024

aneziac opened this issue Feb 24, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@aneziac
Copy link

aneziac commented Feb 24, 2025

Issue description

Thank you for your help with the Katex issue, got everything working there.

When creating a quote in a blog post, I noticed the theme automatically adds opening and closing quotation marks. This creates a grammatical error when attributing a quote, which is even shown as an official example. I think the quotation marks should be left up to the user.

Image

Offending code seems to be here:
https://github.com/jpanther/congo/blob/591610919e6cd2460b581ee259e782de656734c9/assets/css/compiled/main.css#L690C1-L696C2

Theme version

v. 2.11.0

Hugo version

hugo v0.144.1-a79d63a44659b6bc76dcdf223de1637e0bd70ff6+extended linux/amd64 BuildDate=2025-02-18T12:14:07Z VendorInfo=snap:0.144.1

Which browser rendering engines are you seeing the problem on?

No response

URL to sample repository or website

No response

Hugo output or build error messages

@aneziac aneziac added the bug Something isn't working label Feb 24, 2025
@jpanther
Copy link
Owner

Thanks, I agree that this is less than ideal. It's not a bug per se, as this is the expected behaviour. It stems from Tailwind Typography and that's quite an opinionated plugin. I should be able to override the behaviour with something like the below in the Tailwind config... although I'm currently looking at migrating to Tailwind v4 and that might cause issues with this way of fixing it...

  theme: {
    extend: {
      typography: {
        DEFAULT: {
          css: {
            blockquote: {
              quotes: "none",
            },
          },
        },
      },
    },
  },

Let me think on this a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants