Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogt_vox: group references broken by commit: flatten animations ... #35

Closed
dougbinks opened this issue Apr 16, 2022 · 1 comment
Closed

Comments

@dougbinks
Copy link
Collaborator

dougbinks commented Apr 16, 2022

Commit 137ff3d breaks the handling of group references.

Steps to reproduce:

  1. Create a scene in MV with several models
  2. Group the models
  3. Create a reference (SHIFT+move or use icon) and move the new reference somewhere.
  4. Open with ogt_vox before/after this commit. Scene is incorrect after this commit.

Example vox file: https://drive.google.com/file/d/1qpp7WUnk7_w02dCvjI0V3VTLA332dkWq/view?usp=sharing

EDIT: note that for me this fix isn't urgent as I'm able to use the previous commit plus cherry picked resize perf fix as I don't support animations for now.

@dougbinks dougbinks changed the title ogt_vox: group references broken by 137ff3d06a5e919cef9dcdc4fb20ec11decb9cc0 ogt_vox: group references broken by commit: flatten animations ... Apr 16, 2022
@jpaver
Copy link
Owner

jpaver commented Apr 16, 2022

Thanks for the details, PR that fixes this is here: #36.
I've also opened this issue (#37) to add formal test cases to prevent this sort of regression in the future. Thanks again!

@jpaver jpaver closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants