Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets API #29

Open
vivithemage opened this issue May 7, 2019 · 8 comments
Open

Tickets API #29

vivithemage opened this issue May 7, 2019 · 8 comments
Labels
help wanted new api request for a new API to be added to hubspot3

Comments

@vivithemage
Copy link
Contributor

Hi,

I was really pleased to find this - great work. I was wondering if you had any plans for implementing tickets?

https://developers.hubspot.com/docs/methods/tickets/tickets-overview

If not I'm considering making a start on it even if it is simply only to add a ticket. Just wondered what your thoughts were.

Many thanks

@jpetrucciani
Copy link
Owner

Thanks for the kind words, and I hope this library has been helpful for you!

I normally add new APIs/clients as I need them, so at the moment I don't have immediate plans to implement the Tickets API.

Feel free to make a start on it if you need that functionality - I generally get things reviewed and merged in quickly, and a start is much better than nothing! Everyone benefits from contributions 😄

One client that may be good to look at for a start would be the ContactsClient as it has a good variety of operations that are implemented.

@jpetrucciani jpetrucciani added the new api request for a new API to be added to hubspot3 label May 7, 2019
@vivithemage
Copy link
Contributor Author

Thanks for your reply and recommendations - very helpful!

I've made a small start and I'll create a pull request once I've made some more progress.

Thanks again

@jpetrucciani
Copy link
Owner

I've got a bit of time to do some polishing on certain clients, so I'm going to go ahead and merge your current progress so I can get the initial state added in, then I'll add some functionality!

@jpetrucciani
Copy link
Owner

I've got that merged in now! I added some comments and a few small additions, including a get method to get by id.

The first 3 methods on that client are now live on pip as version 3.2.9

I'll leave this issue open for now

@vivithemage
Copy link
Contributor Author

Many thanks for that. Apologies for the delay. I'll likely get stuck back in to this over the next week or so. Thanks again

@selinfildis
Copy link
Contributor

This project was just what i was looking for, thank you so much!!
Quick question about the TicketsClient > update method: do you plan on updating the method so that it also parses some of the properties/pipeline info like create does?
Because currently there is a type hinting error since the request data is supposed to be a list of dicts instead of a dict.
I think I can help contribute and fix this small issue if you'd like me to👼

@vivithemage
Copy link
Contributor Author

Hi @selinfildis, thanks for getting in touch. Sounds great, if you make any changes, I'd be happy to assist with trying them out on my end (if that helps!). Thanks again

@jpetrucciani
Copy link
Owner

Apologies, I've been out on vacation for the holidays!

Absolutely, feel free to open a PR if you'd like! Otherwise, I can take a look at it when I get back in town

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted new api request for a new API to be added to hubspot3
Projects
None yet
Development

No branches or pull requests

3 participants