Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 error page #470

Open
martinheidegger opened this issue Oct 26, 2024 · 7 comments · May be fixed by #473
Open

404 error page #470

martinheidegger opened this issue Oct 26, 2024 · 7 comments · May be fixed by #473
Assignees
@ansh-saini
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@martinheidegger
Copy link
Member

martinheidegger commented Oct 26, 2024 •
edited
Loading

Right now a link to a unspecified url shows the default github 404 page: https://jsconf.jp/anywhere
It would be good to implement a custom 404 page for the jsconf site.

現在、指定されていない URL へのリンクには、デフォルトの github 404 ページが表示されます: https://jsconf.jp/anywhere
jsconf サイト用にカスタム 404 ページを実装すると良いでしょう。
@martinheidegger martinheidegger added enhancement New feature or request good first issue Good for newcomers labels Oct 26, 2024
@ansh-saini
Copy link
Contributor

Hi, I would like to work on this.
Do you have anything specific in mind regarding the design of the 404 page?

@ansh-saini
Copy link
Contributor

How does this look?
image

@martinheidegger
Copy link
Member Author

I don't have something particular in mind but it is important to note that the website contains various generations of website and not just /2024 content

@ansh-saini
Copy link
Contributor

Thanks for the heads up. Do you need a 404 page for all the years?

@martinheidegger
Copy link
Member Author

martinheidegger commented Oct 27, 2024 •
edited
Loading

Yes, for the entire site. (It is not necessary to have a different one every year)

@ansh-saini ansh-saini linked a pull request Oct 28, 2024 that will close this issue
Open
@martinheidegger
Copy link
Member Author

@ansh-saini I erroneously pointed out that its hosted on github, but its actually hosted on netlify. (sorry about this)

→ https://answers.netlify.com/t/custom-404-page-handling/76745

@ansh-saini
Copy link
Contributor

Hey @martinheidegger I'll continue to work on this PR, but can you please add the hacktoberfest-accepted label on this PR so it can count towards my hacktoberfest contributions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansh-saini ansh-saini

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add 404 page ansh-saini/jsconf.jp
2 participants
@martinheidegger @ansh-saini