Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory faults when registering subscribers, services and timers #675

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix memory faults when registering subscribers, services and timers #675

wants to merge 6 commits into from

Conversation

Affonso-Gui
Copy link
Member

@Affonso-Gui Affonso-Gui commented Jun 22, 2021 •
edited
Loading

Fixes #668

  • Add tests
  • Consider garbage collecting old subscribers to avoid memory leak?

@Affonso-Gui Affonso-Gui force-pushed the fix-subscriber-gcguard branch from 4c344a8 to 0757432 Compare October 26, 2022 14:15
Affonso-Gui added a commit to Affonso-Gui/jsk_roseus that referenced this pull request Oct 28, 2022
@Affonso-Gui
Add tests for jsk-ros-pkg#675
add0271
@Affonso-Gui Affonso-Gui force-pushed the fix-subscriber-gcguard branch from 0757432 to 6f74d2b Compare October 28, 2022 08:22
@Affonso-Gui Affonso-Gui changed the title [WIP] Fix possible memory faults when registering subscribers Fix memory faults when registering subscribers, services and timers Oct 28, 2022
Affonso-Gui added a commit to Affonso-Gui/jsk_roseus that referenced this pull request Nov 3, 2022
@Affonso-Gui
Add tests for jsk-ros-pkg#675
a0a4581
@Affonso-Gui Affonso-Gui force-pushed the fix-subscriber-gcguard branch from 6f74d2b to 2eb4e62 Compare November 3, 2022 12:38
Affonso-Gui added a commit to Affonso-Gui/jsk_roseus that referenced this pull request Nov 4, 2022
@Affonso-Gui
Register jsk-ros-pkg#675 tests in CMakeLists
1518839
@Affonso-Gui Affonso-Gui force-pushed the fix-subscriber-gcguard branch from 2eb4e62 to f76aa22 Compare November 4, 2022 03:18
@Affonso-Gui Affonso-Gui force-pushed the fix-subscriber-gcguard branch from f76aa22 to a74ee7e Compare November 4, 2022 03:19
@Affonso-Gui Affonso-Gui force-pushed the fix-subscriber-gcguard branch from a74ee7e to 8bb1082 Compare November 4, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR/PleaseAddTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory faults on subscribers
2 participants
@Affonso-Gui @k-okada