Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote Highlighting Carried To EOF in Objective-C #23

Closed
titoBouzout opened this issue Dec 22, 2014 · 6 comments
Closed

Quote Highlighting Carried To EOF in Objective-C #23

titoBouzout opened this issue Dec 22, 2014 · 6 comments

Comments

@titoBouzout
Copy link
Collaborator

From @nrichards on December 3, 2014 3:25

The quote (") syntax highlighting can carry on highlighting until the end of file, skipping / ignoring an opening quote, honoring only the closing quote, given a specific Objective-C code block.

I expect for the quote character to start highlighting at an opening quote.

OSX
Sublime 3 Build 3065
Clean ST profile

1 Create a new Objective-C file, e.g. "foo.m"
2 Input the following code block:

 - (void)foo {
   NSCAssert((1), @";");
   int four = 4;
 }

3 NOTICE the latter lines, beginning with int, are highlighted as if quoted.

Expecting the int line to not be quoted. Xcode renders this code correctly.

ASIDE: The markdown engine here on github.com appears to also have the same highlighting bug.

Copied from original issue: sublimehq/sublime_text#591

@titoBouzout
Copy link
Collaborator Author

From @nrichards on December 3, 2014 3:27

Workaround: remove the semicolon (;) from the quoted string.

@titoBouzout
Copy link
Collaborator Author

From @FichteFoll on December 3, 2014 3:28

Whatever the syntax definition is doing there, it's likely wrong. The rendered github highlighting is indeed the same as for Sublime.

@titoBouzout
Copy link
Collaborator Author

From @nrichards on December 3, 2014 3:39

Cool - I just reported to GH Support (succinctly, and received a gold star https://assets-cdn.github.com/images/modules/contact/goldstar.gif).

@titoBouzout
Copy link
Collaborator Author

From @nrichards on December 3, 2014 18:40

Issue appears to me to originate in https://github.com/textmate/objective-c.tmbundle. Made another Issue here textmate/objective-c.tmbundle#5.

Should this ST issue be closed?

@titoBouzout
Copy link
Collaborator Author

From @FichteFoll on December 4, 2014 3:15

No, I don't think the shipped bundles are regularly updated and I also don't exactly know where they originate from since Jon never said anything about them (wish he open sourced them, if he could).

So, let's keep these issues until they are fixed downstream.

I've never received a gold star for my reports, but they still fixed most of my concerns. 😄

@wbond
Copy link

wbond commented Apr 27, 2016

This was fixed in dev build 3110

@wbond wbond closed this as completed Apr 27, 2016
@wbond wbond added the R: fixed label Apr 27, 2016
@wbond wbond added this to the Build 3110 milestone Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants