WIP: 8.0.0 development

.circleci/config.yml

@@ -46,7 +46,7 @@ jobs:
                 --enable-maintainer-mode \
                 --enable-audit \
                 --enable-shared --disable-static \
-                CXXFLAGS='-O3 -std=c++17' \
+                CXXFLAGS='-O3 -std=c++20' \
                 CXX=clang++
       - store_artifacts:
           path: config.log

.github/workflows/codeql.yml

@@ -48,7 +48,7 @@ jobs:
             createdb "$(whoami)"
             # Using clang because currently the gcc build fails with an
             # address sanitizer (asan) link error.
-            ./configure --enable-maintainer-mode --enable-audit --disable-static CXXFLAGS='-O1 -std=c++17' CXX=clang++
+            ./configure --enable-maintainer-mode --enable-audit --disable-static CXXFLAGS='-O1 -std=c++20' CXX=clang++
             make -j4 check || (cat test-suite.log && exit 1 || true)
 
       - name: Perform CodeQL Analysis

.readthedocs.yaml

@@ -9,10 +9,16 @@ build:
   tools:
     python: "3.12"
   apt_packages:
+    - "autoconf"
+    - "automake"
+    - "build-essential"
     - "graphviz"
+    - "libpq-dev"
+    - "make"
   jobs:
     pre_build:
-      - "./configure --enable-documentation CXXFLAGS='-O0 -std=c++23'"
+      - "lsb_release -a && g++ --version"
+      - "./configure CXXFLAGS=\"-O0 -std=c++23\" --enable-documentation"
       - "mkdir -p doc/doxygen-html"
       - "cd doc && doxygen"
       - "mkdir -p -- $READTHEDOCS_OUTPUT/html"

CMakeLists.txt

@@ -10,7 +10,7 @@ project(
 )
 
 if(NOT "${CMAKE_CXX_STANDARD}")
-    set(CMAKE_CXX_STANDARD 17)
+    set(CMAKE_CXX_STANDARD 20)
 endif()
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 set(CMAKE_CXX_EXTENSIONS OFF)

NEWS

@@ -1,3 +1,27 @@
+8.0.0
+ - C++20 is now the oldest C++ version that libpqxx supports.
+ - "String conversion" to `std::string_view` is now supported. (#694)
+ - **Beware lifetime** when "converting" a string to `std::string_view`!
+ - Conversion from string to `char const *` is no longer allowed.
+ - Binary data can be any `std::contiguous_range` of `std::byte`. (#925)
+ - Generic `quote()` takes `always_null` into account.
+ - Retired `binarystring` and its headers.  Use `blob` instead.
+ - Retired `connection_base` type alias.  Use `connection`.
+ - Retired `pqxx::encrypt_password()`.  Use the ones in `pqxx::connection`.
+ - Retired `pqxx::prepare::dynamic_params`.  Use `pqxx::params`.
+ - Retired deprecated `stream_to` constructors.  Use factory functions.
+ - Retired `transaction_base::unesc_raw()`.  Use `unesc_bin()`.
+ - Retired `transaction_base::quote_raw()`.  Use `quote()` with `bytes_view`.
+ - Retired result row slicing.
+ - Deprecated `field` constructors are no longer publicly accessible.
+ - Assume compiler supports concepts.
+ - Assume compiler supports integral conversions in `charconv`.
+ - Assume compiler supports spans, ranges, and `cmp_less` etc.
+ - Assume compiler supports `std::remove_cvref_t` etc.
+ - Assume compiler supports `std::filesystem::path`.
+ - Assume compiler supports `[[likely]]` & `[[unlikely]]`.
+ - Assume compiler supports `ssize()`.
+ - Assume compiler supports ISO-646 without needing `<ciso646>` header.
 7.10.1
  - Fix string conversion buffer budget for arrays containing nulls. (#921)
  - Remove `-fanalyzer` option again; gcc is still broken.

README.md

@@ -31,18 +31,8 @@ commits in `master`.  For example, to get version 7.1.1:
 Upgrade notes
 -------------
 
-**The 7.x versions require at least C++17.**  Make sure your compiler is up to
-date.  For libpqxx 8.x you will need at least C++20.
-
-Also, **7.0 makes some breaking changes in rarely used APIs:**
-
-* There is just a single `connection` class.  It connects immediately.
-* Custom `connection` classes are no longer supported.
-* It's no longer possible to reactivate a connection once it's been closed.
-* The API for defining string conversions has changed.
-
-If you're defining your own type conversions, **7.1 requires one additional
-field in your `nullness` traits.**
+**The 8.x versions require at least C++20.**  Make sure your compiler is up to
+date.
 
 
 Building libpqxx

VERSION

@@ -1 +1 @@
-7.10.1
+8.0.0

cmake/pqxx_cxx_feature_checks.cmake

@@ -7,18 +7,6 @@ try_compile(
     PQXX_HAVE_CHARCONV_FLOAT ${PROJECT_BINARY_DIR}
     SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_CHARCONV_FLOAT.cxx
 )
-try_compile(
-    PQXX_HAVE_CHARCONV_INT ${PROJECT_BINARY_DIR}
-    SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_CHARCONV_INT.cxx
-)
-try_compile(
-    PQXX_HAVE_CMP ${PROJECT_BINARY_DIR}
-    SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_CMP.cxx
-)
-try_compile(
-    PQXX_HAVE_CONCEPTS ${PROJECT_BINARY_DIR}
-    SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_CONCEPTS.cxx
-)
 try_compile(
     PQXX_HAVE_CXA_DEMANGLE ${PROJECT_BINARY_DIR}
     SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_CXA_DEMANGLE.cxx
@@ -31,18 +19,10 @@ try_compile(
     PQXX_HAVE_GCC_VISIBILITY ${PROJECT_BINARY_DIR}
     SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_GCC_VISIBILITY.cxx
 )
-try_compile(
-    PQXX_HAVE_LIKELY ${PROJECT_BINARY_DIR}
-    SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_LIKELY.cxx
-)
 try_compile(
     PQXX_HAVE_MULTIDIM ${PROJECT_BINARY_DIR}
     SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_MULTIDIM.cxx
 )
-try_compile(
-    PQXX_HAVE_PATH ${PROJECT_BINARY_DIR}
-    SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_PATH.cxx
-)
 try_compile(
     PQXX_HAVE_POLL ${PROJECT_BINARY_DIR}
     SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_POLL.cxx
@@ -55,14 +35,6 @@ try_compile(
     PQXX_HAVE_SOURCE_LOCATION ${PROJECT_BINARY_DIR}
     SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_SOURCE_LOCATION.cxx
 )
-try_compile(
-    PQXX_HAVE_SPAN ${PROJECT_BINARY_DIR}
-    SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_SPAN.cxx
-)
-try_compile(
-    PQXX_HAVE_SSIZE ${PROJECT_BINARY_DIR}
-    SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_SSIZE.cxx
-)
 try_compile(
     PQXX_HAVE_STRERROR_R ${PROJECT_BINARY_DIR}
     SOURCES ${PROJECT_SOURCE_DIR}/config-tests/PQXX_HAVE_STRERROR_R.cxx

config-tests/no_need_fslib.cxx

@@ -1,21 +1,13 @@
 // Check whether we need to link to the stdc++fs library.
 //
-// We assume that the presence of the <filesystem> header means that we have
-// support for the basics of std::filesystem.  This check will succeed if
-// either there is no <filesystem> header, or there is one and it works without
-// any special options.  If the link fails, we assume that -lstdc++fs will fix
-// it for us.
+// This check will succeed if std::filesystem::path works without any special
+// options.  If the link fails, we assume that -lstdc++fs will fix it for us.
 
+#include <filesystem>
 #include <iostream>
 
-#if __has_include(<filesystem>)
-#  include <filesystem>
-#endif
-
 
 int main()
 {
-#if __has_include(<filesystem>)
   std::cout << std::filesystem::path{"foo.bar"}.c_str() << '\n';
-#endif
 }

configitems

@@ -5,21 +5,14 @@ PACKAGE_STRING	internal	autotools
 PACKAGE_TARNAME	internal	autotools
 PACKAGE_VERSION	internal	autotools
 PQXX_HAVE_ASSUME	public	compiler
-PQXX_HAVE_CHARCONV_INT	internal	compiler
 PQXX_HAVE_CHARCONV_FLOAT	internal	compiler
-PQXX_HAVE_CMP	public	compiler
-PQXX_HAVE_CONCEPTS	public	compiler
 PQXX_HAVE_CXA_DEMANGLE	internal	compiler
 PQXX_HAVE_GCC_PURE	public	compiler
 PQXX_HAVE_GCC_VISIBILITY	public	compiler
 PQXX_HAVE_MULTIDIM	public	compiler
-PQXX_HAVE_LIKELY	public	compiler
-PQXX_HAVE_PATH	public	compiler
 PQXX_HAVE_POLL       internal        compiler
 PQXX_HAVE_SLEEP_FOR	internal	compiler
 PQXX_HAVE_SOURCE_LOCATION	public	compiler
-PQXX_HAVE_SPAN	public	compiler
-PQXX_HAVE_SSIZE	public	compiler
 PQXX_HAVE_STRERROR_R	public	compiler
 PQXX_HAVE_STRERROR_S	public	compiler
 PQXX_HAVE_THREAD_LOCAL       internal        compiler