Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should trusted metadata be documented in notebook file format? #349

Open
krassowski opened this issue Feb 19, 2023 · 4 comments
Open

Should trusted metadata be documented in notebook file format? #349

krassowski opened this issue Feb 19, 2023 · 4 comments

Comments

@krassowski
Copy link
Member

nbformat (Python package) handles trusted as described in https://nbformat.readthedocs.io/en/latest/api.html#module-nbformat.sign. The Cell metadata chapter of the Notebook file format does not describe trusted. Should trusted be added to specification, or is this an implementation detail which was intentionally omitted? If it is omitted by choice, what is the right place to document/discuss quirks around it?

Cross-referencing related discussions:

@westurner
Copy link
Contributor

westurner commented Feb 19, 2023 via email

@Carreau
Copy link
Member

Carreau commented Feb 20, 2023

IIRC, trust metadata should not be part of the format as is should be only a transiant key that is not saved.

@krassowski
Copy link
Member Author

If that is not part of nbformat, then where should the specification for it live?

@Carreau
Copy link
Member

Carreau commented Feb 21, 2023

Good question, it use to be that the schema/validation had two modes:

  • In memory and
  • On disk
    Those transient keys should definitely not be on disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants