fix: samsungpay script mount condition correction #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aritro2002
requested review from
seekshiva,
PritishBudhiraja,
ArushKapoorJuspay and
sakksham7
as code owners
|
Review changes with |
aritro2002
added
the
Ready for Review
Sanskar2001
requested changes
Feb 12, 2025
src/hyper-loader/Elements.res
Outdated
|
|
||
| mountSamsungPayScript(samsungPayPresent) |
There was a problem hiding this comment.
if samsung pay is present then only call this function
There was a problem hiding this comment.
If I call mountSamsungPayScript inside the if block when Samsung Pay is present, I will need to duplicate the same logic in both the if and else blocks. Additionally, since a similar implementation would be required for Google Pay, it would lead to even more repeated code.
To keep the implementation clean and avoid redundancy, I believe the current approach is more maintainable. Let me know if you have any suggestions on structuring it better without introducing duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The Samsung Pay script should be mounted only when Samsung Pay is present and the script is not already mounted. Previously, we only checked whether it was mounted.
How did you test it?
I tested by running it in demo store.
Checklist
npm run re:build