Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] remove redundant variants from PermissionGroup #6983

Open
2 tasks done
kashif-m opened this issue Jan 3, 2025 · 0 comments · May be fixed by #6985
Open
2 tasks done

[CHORE] remove redundant variants from PermissionGroup #6983

kashif-m opened this issue Jan 3, 2025 · 0 comments · May be fixed by #6985
Assignees
Labels
C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet

Comments

@kashif-m
Copy link
Contributor

kashif-m commented Jan 3, 2025

Feature Description

Few variants in PermissionGroup enum were kept in the application code for backwards compatibility. These variants are directly stored as TEXT in DB which forces the application to ensure backwards compatibility during staggered releases. Since new variants were added and deployed, old variants can be removed post running the DB migrations.

Possible Implementation

  1. Add DB migration for updating any existing values from older variants to new variants
  2. Remove variants from application code
  3. Deploy

This still leaves a small time window where users can make use of older variants during staggered deployment once the migrations have run, that can be manually avoided by running migrations several times during staggered release, if required.

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

Yes, I am willing to submit a PR!

@kashif-m kashif-m added C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet labels Jan 3, 2025
@kashif-m kashif-m self-assigned this Jan 3, 2025
@kashif-m kashif-m linked a pull request Jan 3, 2025 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant