Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in 2.8.7 assigning grades to activities while not subscribed to Poodll #27

Open
dustinbrisebois opened this issue Jun 12, 2017 · 1 comment

Comments

@dustinbrisebois
Copy link

When attempting to assign a grade to an Assignment in an LMS site where Poodll is installed but not subscribed to site errors out with:

Notice: Undefined property: stdClass::$filter_poodll_usecourseid in /var/www/data/default/lms/filter/poodll/classes/poodlltools.php on line 523
Skip to main content

The line of code:

  if ($CFG->filter_poodll_usecourseid) {
  	$courseid = $COURSE->id;
  } else {
  	$courseid = -1;
  }

Assumes poodll services are available -- this should be caught either with an isset($CFG->filter_poodll_usecourseid) or some other logic check in the workflow.

The grade is assigned once the error is accepted.

@justinhunt
Copy link
Owner

Indeed. Its redundant really anyway that section. Thanks for the report, I will see what I can do. It won't be for a few days though.

J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants