Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: package settings in dedicated settings.go files #1130

Open
bt-justtrack opened this issue Jul 24, 2024 · 1 comment · May be fixed by #1137
Open

config: package settings in dedicated settings.go files #1130

bt-justtrack opened this issue Jul 24, 2024 · 1 comment · May be fixed by #1137
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bt-justtrack
Copy link
Contributor

To improve searchability / introspection into where our settings come from for different services we want to move these settings structs into a dedicated settings.go file for each package. Optionally if there are too many settings we want a settings_*.go file structure.

@bt-justtrack bt-justtrack added enhancement New feature or request good first issue Good for newcomers labels Jul 24, 2024
@bt-justtrack
Copy link
Contributor Author

Note: pkg/kvstore/settings.go features two InMemory(Configuration|Settings) having the same fields but the one used in the constructor does not have defaults set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant