-
Notifications
You must be signed in to change notification settings - Fork 199
AssetSync uploading uncompiled module code #232
Comments
@benwalsh Thanks so much for looking into this! I read your description and am running through scenarios in my head. |
@benwalsh Could you verify that these lines are being executed? This merges |
That's the magic I was trying to recreate on the AssetSync side -- blending the sprockets manifest and the RJS one.
But the file being syncd to S3 is still the "source" file located at Thanks for your help. This is tantalizingly close and is going to be so great when it gets there. |
@benwalsh Ahhh, notice it's modifying the manifest attached to |
It is possible that there's some user error at work here again. Because my source file had not changed over several iterations and configuration changes, the destination sha hadn't changed, the cache was not invalidated, so Cloudfront was still serving up the old version. I think it could be that simple ... |
@benwalsh Any progress on this? AssetSync has been a thorn in my side for a while now, and its incompatible behavior has cropped up at least once before. |
I had a caching issue that was the direct cause of this problem. I have had to get a bit creative to skip the mini-manifest where the entire filemap is output to a script tag -- I only want one script file per page, so this is unnecessary, and we restrict inline script tags, so I've monkeypatched the |
@benwalsh I may have identified the issue. Would you be so kind as to replace those two lines in question and just use |
@benwalsh Closing this issue, because I've file one upstream. |
Using
flight
with a collection of "per-page" files that were previously compiled via stand-alone RJS. I'm migrating torequirejs-rails
. Each of the existing per-page files is now being wrapped in a template that pulls injquery
and acommon
package. (Some background in Issue #228)Each per-page file then looks like this:
app/assets/javascripts/gr-page-home.js
:and
requirejs.yml
includes:Now when I deploy, the rake task runs and generates the "built" (and gzipped) versions of the per-page file I want:
but the version that ends up on the CDN is the "source" file -- the 7 lines of original JS.
Is this an issue with how I'm configuring AssetSync, or how I'm configuring RequireJS-Rails, or both? (Or neither?)
I have been trying to hack the AssetSync rake task to change the order in which things happen or to move the compiled files around before continuing, but nothing has worked for me yet.
The text was updated successfully, but these errors were encountered: