Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make checkautopista "checkcarretera" #24

Open
yopaseopor opened this issue Sep 26, 2016 · 7 comments
Open

Make checkautopista "checkcarretera" #24

yopaseopor opened this issue Sep 26, 2016 · 7 comments

Comments

@yopaseopor
Copy link

First of all, what a great tool. Second I want to make a suggestion: Transform checkautopista to checkcarretera (checkroad) allowing other ways than motorways, also roads without relations.
And also , as your software make the destination traffic sign, what about other traffic signs (with codes extracted from OSM data)?
You can find it in https://taginfo.openstreetmap.org/projects/traffic_signs#tags
You can take pics and codes from https://github.com/yopaseopor/beta_style_josm/tree/master/traffic_signs

@k1wiosm
Copy link
Owner

k1wiosm commented Sep 28, 2016

What is your idea behind allowing roads other than motorways? The main thing about checkautopista is that you can see all the exits of a motorway at once, see how they are mapped, and see what information they are missing. Other roads don't have exits, they have intersections.

I will think about allowing motorways without relation and I will take a look at those traffic signs.

Thank you for the suggestions!

@claudiush
Copy link
Contributor

The highway=motorway_junction is also being used on other road categories. If you look at https://wiki.openstreetmap.org/wiki/Tag:highway%3Dmotorway_junction it even spells out: This is usually found along a highway=motorway, but is also applicable to other roads with numbered or named junctions including some highway=trunk and highway=primary roads.

e.g. if you think of Estonia which doesn't have a single kilometer of highway=motorway but trunk roads where checkautopista works fine: http://k1wiosm.github.io/checkautopista2/?id=1751143&lat=58.6655&lon=23.4393&z=8

I think broadening the filter to include at least trunk roads, possibly even primaries is worth investigating.

@zlavergne
Copy link

I first want to say that you have a great tool here!

I also think that it would be useful for this tool to also work for roads other than motorways as well as all links rather than only "motorway_junctions".

For both navigation purposes and completeness of the map, a link should have at least on of the following: "destination=", "destination:ref=", "destination:street=", "destination:ref:to=", and a few others. Amongst other criteria that I'm sure you know, for example: a "motorway_junction" should be connected to a" _link" (and the link's "junction:ref=" should have the same reference as the junction's ref) and also that a "_link" that leads into a road with a reference should have a "destination:ref=" tag with the road's ref.

I think allowing the filters to show for all links would be extremely useful. If this is something you would be interested in implementing (or maybe need help with), I have some ideas as to how to properly check for these sorts of things.

@k1wiosm
Copy link
Owner

k1wiosm commented Aug 9, 2017

Thank you for your comments!

@zlavergne, can you show me an example of a link you would like to be shown in checkautopista?

@zlavergne
Copy link

zlavergne commented Aug 9, 2017

Here's an example of a link in Iceland that is incorrect and incomplete:
https://www.openstreetmap.org/way/5188855

screen shot 2017-08-09 at 2 35 02 pm

I think your tool could flag the link for the following reasons (in order of decreasing importance):

  • the link has no destination tags (destination=*, destination:ref=*, destination:street=*, destination:ref:to=*, destination:int_ref=*, or destination:country=*)
  • the link leads to a road with a ref=* but the link doesn't have a destination:ref=* tag (if a link takes you to a road with a ref tag, the link needs the destination:ref=* tag
  • the link has a ref=* tag (links can have a junction:ref=* tag if the motorway_junction has a reference)
  • the link has a name=* tag (links very rarely have names - this could me a minor flag as there is a chance it is correct)

I also think this check could be completed with the flags you already have:

  • a motorway_junction with a ref=* should be connected to a link with junction:ref=* with the same value

@kevinp2
Copy link

kevinp2 commented Oct 12, 2022

This tool is fantastic and I would love to see it extended to other highway types, at least primary. Even if they are not motorways, it is still useful to check things like lanes and maxspeed.

Perhaps a quick enhancement to allow for directly typing in the relation id for non-motorway highways?

@claudiush
Copy link
Contributor

@kevinp2 You can already drop relation IDs for non-motorway routes in the "Get by relation ID" field in the UI:
Checkautopista_relationID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants