Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1beta2 changes #62

Open
1 task
richardcase opened this issue Oct 12, 2023 · 5 comments
Open
1 task

v1beta2 changes #62

richardcase opened this issue Oct 12, 2023 · 5 comments

Comments

@richardcase
Copy link
Collaborator

This issue is to track API changes that the project wants to make as part of an API bump from v1beta1 to v1beta2.

@zawachte
Copy link
Collaborator

Thanks @richardcase. We should probably also do an audit of k3s flags that are missing and make sure v1beta2 considers them in its design.

@richardcase
Copy link
Collaborator Author

Sounds good to me.

I'll also check what we have added to the RKE2 provider to see if there is anything we add here as well.

@philjb
Copy link
Contributor

philjb commented Oct 17, 2023

I think #63 is part of the consideration for this version change (just linking them together).

@mogliang
Copy link
Collaborator

link #73

Need add machineSpec properties nodeDeletionTimeout in KThreesControlPlaneMachineTemplate

Better add nodeVolumeDetachTimeout as well in case we need it in future.

@nasusoba
Copy link
Contributor

link #73

Need add machineSpec properties nodeDeletionTimeout in KThreesControlPlaneMachineTemplate

Better add nodeVolumeDetachTimeout as well in case we need it in future.

Seems that we do not have these fields yet, should we also add them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants