Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to allow multiple accounts #23

Open
kanimaru opened this issue Aug 8, 2024 · 5 comments
Open

Add feature to allow multiple accounts #23

kanimaru opened this issue Aug 8, 2024 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@kanimaru
Copy link
Owner

kanimaru commented Aug 8, 2024

Find an Idea how to support multiple accounts at all. Any Ideas are welcome!

@kanimaru kanimaru added enhancement New feature or request help wanted Extra attention is needed labels Aug 12, 2024
@lublak
Copy link
Contributor

lublak commented Aug 16, 2024

i think threading would be a good option here, every account its own thread?
https://docs.godotengine.org/en/stable/tutorials/performance/using_multiple_threads.html

@kanimaru
Copy link
Owner Author

It's not a performance issue its a storage and usage issue. Cause how do you call the method for a specific user etc. everything needs to be rewritten to support multiple users at once. Maybe some context variables could work something like TwitchService.use(user) but then you may have the problem with await methods and async stuff.

@lublak
Copy link
Contributor

lublak commented Aug 17, 2024

It's hard because this project use a lot of static stuff. Better would be an object based design. So you could use new TwitchService(user) but also then everything needs to be rewritten.

@kanimaru
Copy link
Owner Author

Should find a backwards compatible solution probably. I like your idea with new TwitchService(user) idea

@lublak
Copy link
Contributor

lublak commented Aug 17, 2024

@kanimaru it could be backwards compatible, just wrap the objects into the static approach. So you have the best of both worlds. It's just an idea. In any case, you have to put in a lot of work. It doesn't matter what you do. It's actually a complete rework.

@kanimaru kanimaru added this to the v2 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants