Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Client ID and Client Secret when Exporting #34

Open
eumario opened this issue Aug 24, 2024 · 3 comments
Open

Missing Client ID and Client Secret when Exporting #34

eumario opened this issue Aug 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@eumario
Copy link

eumario commented Aug 24, 2024

Affected Version: 1.2

Problem:
When running Twitcher in the Editor for a project, everything works as expected. However, when exporting and distributing the project to other people, the project fails to load the Client ID and Client Secret.

Cause:
When looking through the problem, it comes down to the client id and secret being stored in the user:// folder, which is not bound together with the exported game, causing issues with not being able to find the information needed.

Possible Solution(s):
The Client ID and Secret can be written to the res:// folder as a configuration file, that needs to be included in the exported project. Currently, it's being stored as a Godot encrypted data file, but could easily be stored in a Custom Resource, with the secret being encrypted and stored a PackedByteArray in the resource file, keeping the encryption so the security of the client id and secret is not exposed.

@kanimaru
Copy link
Owner

Then how do you want to encrypt it / where is the key for the encryption saved? The reason to save that stuff in user was that noone accidently commits their client secret to the repository.

@eumario
Copy link
Author

eumario commented Aug 24, 2024

This is what Godot Recommends. As the .godot folder should not be committed to the Github repository, and most of the gitignore templates I know, have .godot folder ignored.
https://docs.godotengine.org/en/stable/tutorials/export/exporting_projects.html#configuration-files

@kanimaru kanimaru added the enhancement New feature or request label Aug 25, 2024
@kanimaru
Copy link
Owner

kanimaru commented Oct 3, 2024

Do you know how the content of the file should / would look like I don't find methods to write to it and I don't want to messup existing file formats when I would put the stuff into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants