Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linters for test packages #2962

Open
saima-s opened this issue Jun 26, 2024 · 6 comments
Open

Enable linters for test packages #2962

saima-s opened this issue Jun 26, 2024 · 6 comments

Comments

@saima-s
Copy link
Contributor

saima-s commented Jun 26, 2024

Is your feature request related to a problem? Please describe.
As of now linters are disabled from test packages in .golangci.yaml file:

issues:
  exclude-rules:
    - path: '_test.go'
      linters:
        - errcheck                      # Errors may be ignored in tests.
        - unparam                       # Tests might have unused function parameters.
        - lll
        - dupl
        - misspell
        - nestif
        - gci

Describe the solution you'd like
After enabling this linter, fix all kind of linter issues coming up in test packages.

@anishbista60
Copy link
Contributor

anishbista60 commented Aug 15, 2024

/assign
please assign to me. I'll work .

@julio-lopez
Copy link
Contributor

This should not have been closed in #3052

@hairyhum
Copy link
Contributor

hairyhum commented Aug 29, 2024

@anishbista60 can you please provide more context to the PRs mentioning that linters are actually being added and not removed?

@hairyhum hairyhum removed the triage label Aug 29, 2024
@anishbista60
Copy link
Contributor

anishbista60 commented Aug 29, 2024

@hairyhum ok ok . Sorry , description was wrong.

julio-lopez added a commit that referenced this issue Sep 5, 2024
Refs:
#3034
#2962

--
Signed-off-by: Anish Bista <[email protected]>
Co-authored-by: Julio López <[email protected]>
@github-project-automation github-project-automation bot moved this from To Be Triaged to Done in Kanister Sep 23, 2024
@anishbista60
Copy link
Contributor

anishbista60 commented Sep 23, 2024

@julio-lopez I think it should not be closed.

@julio-lopez
Copy link
Contributor

@julio-lopez I think it should not be closed.

It was automatically closed because this PR's description said "fixes: #2962"

@anishbista60 Please make sure that the PRs and the commits say "Ref #2962" and not "fixes".

@julio-lopez julio-lopez reopened this Sep 23, 2024
@github-project-automation github-project-automation bot moved this from Done to To Be Triaged in Kanister Sep 23, 2024
@hairyhum hairyhum removed the triage label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Be Triaged
Development

No branches or pull requests

4 participants