-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow imagePullSecrets configurable on operator Deployment #2999
Comments
Thanks for opening this issue 👍. The team will review it shortly. If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md. If you haven't already, please take a moment to review our project's Code of Conduct document. |
Hi @ifalex, thanks for posting that. Can you please clarify if you're not able to use kanister without these? Do you have a workaround? If not, please let us know. |
Hi @hairyhum. There are some scenarios where you want to use imagePullSecrets for air gap environments with private registry and authentication. Also this is a best practice in ecosystem so allowing this setting could improve the value of the chart delivered. |
Can you please share your changes and/or tests you use? |
Sure. Will do. |
Is your feature request related to a problem? Please describe.
Deployment for kanister-operator is quite limited in options, therefore it fails under many kube-score/kube-linter tests.
Allowing more options to the deployment file would benefit from robustness perspective and best practices around helm chart creation.
To list a few:
Describe the solution you'd like
Improve Deployment/Helm chart to make kanister-operator helm chart a more production ready option (currently won't work on Openshift for example)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Environment
Kubernetes Version/Provider: ...
Storage Provider: ...
Cluster Size (#nodes): ...
Data Size: ...
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: