-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: --parallel flag can be flaky at times #306
Comments
happens a lot lately, definitely worth trying with retries |
Been flaky really often, so took another look at this -- essentially it's flaky because pip not really meant to be running in parallel, e.g. it can observe intermediate metadata state from other package and crash. I thought we could benefit a lot at least from downloading in parallel pypa/pip#825. There is a I took a look what's taking so much time using
The above sums up to about 2.5 minutes, which is like 80% of time the whole tox pipeline is running, so worth digging how to optimize this. In the meantime going to disable parallel install on ci, since it fails so much it defeats the purpose basically (to merge things faster) |
It's been so flaky it ends up taking more time to merge stuff. See #306
It's been so flaky it ends up taking more time to merge stuff. See #306
For |
For git repositories it's basically the same issue -- there are no wheels so it takes a while to build them. Kinda odd that there is no builtin support for parallelization during wheel building.
|
I think with uv perhaps this won't be an issue anymore |
E.g. see here #304 and we had some other issues with it before
I guess it could use some stress testing to figure out what actually results in race conditions, or perhaps make it a bit more defensive (add some retries) -- at least during CI this should be acceptable
The text was updated successfully, but these errors were encountered: