Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19.3 backport #15

Open
Omena0 opened this issue Aug 5, 2023 · 7 comments · May be fixed by #19
Open

1.19.3 backport #15

Omena0 opened this issue Aug 5, 2023 · 7 comments · May be fixed by #19

Comments

@Omena0
Copy link

Omena0 commented Aug 5, 2023

Is your feature request related to a problem? Please describe.
I'd like to change the brand of my client, but since it is on 1.19.3 i cant get a version of this mod.

Describe the solution you'd like
Backport for 1.19.3

Describe alternatives you've considered
I've searched for an alternative but havent found any that would support 1.19.3

Additional context
Cool mod :) Thanks.

@Nukecraft5419
Copy link
Contributor

Hi I'm a Contributor I was thinking of making a pull where I initially create several split branches in order to be able to develop the versions in a split way and put both 1.19.4 and 1.19.3 although in reality you could already run version 1.19.4 on 1.19.3 if you want I'll explain how

@Omena0 Omena0 closed this as completed Aug 21, 2023
@Omena0 Omena0 reopened this Aug 21, 2023
@Nukecraft5419
Copy link
Contributor

This is a momentary fix just to get the mod running in 1.19.3 if you notice that it's a zip file you have to open and extract it and put that .json file in the config folder, I had to put the file in a zip because GitHub doesn't support json files which is strange I tried it and it works tell me if it works just in case I'll leave you a step I did with the screens

File: fabric_loader_dependencies.zip

image

image

image

@Omena0
Copy link
Author

Omena0 commented Aug 23, 2023

Yes ikr

@Nukecraft5419
Copy link
Contributor

In a few days I'm going to send a couple of PRs with the modifications where the support is divided into various branches for the various versions so that it will be easy for the creator to develop the various versions. I was planning to start with fabric 1.12 up to 1.20.1 and perhaps also for forge.

@kaylendog
Copy link
Owner

In a few days I'm going to send a couple of PRs with the modifications where the support is divided into various branches for the various versions so that it will be easy for the creator to develop the various versions. I was planning to start with fabric 1.12 up to 1.20.1 and perhaps also for forge.

I'm happy to do the multiple version support, see #16, but I can't support a forge implementation because my Forge abilities are flaky at best and I wouldn't have time to maintain it longterm. Feel free to fork, though!

@Nukecraft5419
Copy link
Contributor

In fact I wanted to do the support to learn better how to make mods and so on, only I would divide the various versions into various branches so that I could succeed better in development

@kaylendog
Copy link
Owner

In fact I wanted to do the support to learn better how to make mods and so on, only I would divide the various versions into various branches so that I could succeed better in development

That's fair, but maintaining multiple concurrent branches will be a nightmare! It will be much easier to maintain one single branch capable of building to many versions and, if necessary, use release branches when there need to be extra tweaks.

@kaylendog kaylendog linked a pull request Dec 4, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants