Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FaultTreeAndSystemOverviewTable and FaultTreeAndSystemOverviewCardsList #423

Open
blcham opened this issue Jun 18, 2024 · 1 comment

Comments

@blcham
Copy link
Contributor

blcham commented Jun 18, 2024

          This is quite a strange class to me. (CC @Kasmadei )

The entire class seems to me like having basically no shared code for faultTreeTable and systemTable, but still it shares one file and this very weird name.

I suggest rethinking this design, possibly moving ftaTreeOverview and systemOverview functionality to separate subclasses and possibly renaming this class something like "OverviewTable" if there is something that can be shared ...

The same goes to FaultTreeAndSystemOverviewCardsList.

Originally posted by @blcham in #405 (comment)

@blcham
Copy link
Contributor Author

blcham commented Jun 18, 2024

Currently low priority task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant