Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EP] Support dash in identifier? #1867

Open
He1pa opened this issue Feb 24, 2025 · 2 comments
Open

[EP] Support dash in identifier? #1867

He1pa opened this issue Feb 24, 2025 · 2 comments

Comments

@He1pa
Copy link
Contributor

He1pa commented Feb 24, 2025

Enhancement

do we need to support dash in identifier?

e.g.,

api-Version = "apps/v1"
@He1pa
Copy link
Contributor Author

He1pa commented Feb 24, 2025

related issue: #1787

@tvandinther
Copy link

I support this if modules are also updated to support dashes for consistency. Otherwise we have a situation where my-app = {} is valid but import .my-app and my-app.Schema{} is not.

I personally think that the semantic distinction between fields and identifiers is enough to explain the issue in #1787. Wrapping the top level in {} to turn it into a single dict export to allow string-literals as fields makes sense.

My motivation for semi-supporting the change is to align module naming with that of file/directory naming and by extension, that would include supporting the dash in identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants