Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: merge into eslint-plugin-jsonc #166

Open
JounQin opened this issue Jan 19, 2024 · 8 comments
Open

Proposal: merge into eslint-plugin-jsonc #166

JounQin opened this issue Jan 19, 2024 · 8 comments

Comments

@JounQin
Copy link

JounQin commented Jan 19, 2024

In case you are not aware, there is a https://github.com/ota-meshi/eslint-plugin-jsonc built with correct jsonc-eslint-parser, I think we should work together to benefit to the whole community.

cc @ota-meshi

@kellyselden
Copy link
Owner

Thanks for the suggestion, but closing as I'm not planning on working on this currently.

@JounQin
Copy link
Author

JounQin commented Jan 19, 2024

I'm not quite sure to understand, in README:

I wouldn't mind getting this merged into eslint-plugin-node or eslint-plugin-json.

I believe eslint-plugin-jsonc is a much better solution for .json files than the above two packages.

@kellyselden
Copy link
Owner

My apologies! I forgot about that section of the README.

@kellyselden kellyselden reopened this Jan 19, 2024
@ota-meshi
Copy link

I think it's probably best if all rules are merged into eslint-plugin-package-json.
JoshuaKGoldberg/eslint-plugin-package-json#42

eslint-plugin-package-json uses jsonc-eslint-parser, so it can be used together with eslint-plugin-jsonc.

@JounQin
Copy link
Author

JounQin commented Jan 20, 2024

json-files aims not only package.json, right?

@ota-meshi
Copy link

I think everything except the json-files/validate-schema rule mentions package.json.

An alternative to the json-files/validate-schema rule is eslint-plugin-json-schema-validator, which checks JSON using a JSON schema.

@JounQin
Copy link
Author

JounQin commented Jan 20, 2024

cc @JoshuaKGoldberg

@JoshuaKGoldberg
Copy link

JoshuaKGoldberg commented Jan 20, 2024

Hiyall! Sure, if anybody wants to use eslint-plugin-package-json for package.json-specific things, that'd be great. I set up a tracking issue on JoshuaKGoldberg/eslint-plugin-package-json#42 with a comparison of all the package.json-oriented rules I could find in the ecosystem. That includes eslint-plugin-json-files. It's on my 2024 agenda to get them all merged into eslint-plugin-package-json.

At any rate, it seems to me that once the package.json-specific rules from this plugin are merged into eslint-plugin-package-json, then yeah, there won't be anything this plugin does that isn't captured elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants