Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Toggle hide filter" command doesn't show entries added by "Quick Action" #3

Open
LinkZ-LynX opened this issue Nov 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@LinkZ-LynX
Copy link

LinkZ-LynX commented Nov 4, 2023

What happened?

The problem: For individual filters, the "Toggle hide filter" command doesn't show entries that were added by "Quick Action" for hiding by right-clicking in the Explorer pane.

image

The reason: Entries added by "Quick Action" don't have a name attribute. After filling in the name value for this path entry the "Toggle hide filter" command correctly shows missing the entry.

image

What did you expect to happen?

The "Toggle hide filter" command should show entries that were added by "Quick Action" for hiding in the Explorer pane.
The simplest solution IMHO is to automatically fill the name attribute value with the hiding folder/file name.

Can you reproduce the bug, if so how? As detailed but minimal as possible.

Just use "Quick Action" to hide in the Explorer pane and try to toggle that single hide filter using the command.

Other?

No response

Plugin version

1.1.3

Obsidian version

1.4.16

OS

Windows

@LinkZ-LynX LinkZ-LynX added the bug Something isn't working label Nov 4, 2023
@kelszo
Copy link
Owner

kelszo commented Nov 5, 2023

This was sort of intentional, but I will add so that new filters automatically get a “Unnamed filter ” name 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants