Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numberOfReviewers is misleading when useReviewGroups is enabled #24

Open
paniko0 opened this issue Jun 9, 2020 · 0 comments
Open

numberOfReviewers is misleading when useReviewGroups is enabled #24

paniko0 opened this issue Jun 9, 2020 · 0 comments

Comments

@paniko0
Copy link

paniko0 commented Jun 9, 2020

Assuming the following configuration, I'd expect that only one reviewer would be selected given that numberOfReviwers is set to 1, instead, it returns 3 values: user1, user2, and a user in the charlie group.

addReviewers: true

numberOfReviewers: 1

useReviewGroups: true

reviewGroups:
  alpha:
    - user1
  bravo:
    - user2
  charlie:
    - user3
    - user4
    - user5

I believe either the name of the configuration numberOfReviwers is misleading when useReviewGroups is enabled, or there's a bug where it assigns more than one reviewer to the PR.

I can work on a PR to fix the problem, I just need to know which approach you guys think it's the best. Personally, I think numberOfReviewers should always be respected regardless of the number of developers each group has. I'd also include a configuration to the group, so it can select one or multiple developers per group to be used later by the numberOfReviewers variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant