Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different decimal/thousands separators #201

Open
schnerd opened this issue Aug 19, 2018 · 2 comments
Open

Support different decimal/thousands separators #201

schnerd opened this issue Aug 19, 2018 · 2 comments
Labels
enhancement An update of a existing feature

Comments

@schnerd
Copy link
Collaborator

schnerd commented Aug 19, 2018

Is your feature request related to a problem? Please describe.
There are numerous international datasets that Kepler cannot process because they use different decimal separators other than a period, such as this Buenos Aires Taxi Dataset, which uses a comma instead of a period.

In addition to commas instead of decimals, there are a few other formatting types that may be worth supporting: https://en.wikipedia.org/wiki/Decimal_separator#Examples_of_use

Describe the solution you'd like
I think in an ideal world Kepler would automatically detect the number formatting type, in a similar way that it detects the data type. However, I think letter people enter custom thousands/decimal separators is another option (numeral.js takes this approach).

I think this type of input parsing problem isn't too dissimilar from supporting CSVs with different delimiters (#196). It seems like the upload dialog could maybe have a couple more configuration options after upload–including changing the column delimiter, thousands/decimal separators, and possibly re-adjusting datatypes (#191).

Describe alternatives you've considered
You can transform this data use excel or another python script, but it would be awesome to support these datasets out of the box.

@macrigiuseppe
Copy link
Collaborator

linked to: uber-web/type-analyzer#7

@rusosnith
Copy link

What happened to this? It's so US centric to have a tool only compatible with the units/delimiters used in one country.
This could be implemented so easily!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An update of a existing feature
Projects
None yet
Development

No branches or pull requests

3 participants