Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using test set as validation set #1711

Closed
bz36912 opened this issue Jan 5, 2024 · 1 comment · Fixed by #1719
Closed

using test set as validation set #1711

bz36912 opened this issue Jan 5, 2024 · 1 comment · Fixed by #1719
Assignees
Labels

Comments

@bz36912
Copy link

bz36912 commented Jan 5, 2024

Issue Type

Bug

Source

source

Keras Version

Keras2.13

Custom Code

Yes

OS Platform and Distribution

Windows 11

Python version

3.8.5

GPU model and memory

No response

Current Behavior?

In examples/vision/pointnet.py. You seem to use used your test set as validation set in line 263:
model.fit(train_dataset, epochs=20, validation_data=test_dataset)
This would cause the performance and predictive ability of your model to be overly optimistic, since the test set is not separate from your training process. The model is likely to perform poorly with unseen data/points.

Standalone code to reproduce the issue or tutorial link

examples/vision/pointnet.py line 263:
`model.fit(train_dataset, epochs=20, validation_data=test_dataset)`

Relevant log output

No response

@simeetnayan81
Copy link

I'd like to contribute. @sachinprasadhs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants