Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests passing for external contributor #357

Open
loicmathieu opened this issue Aug 14, 2024 · 0 comments
Open

Make tests passing for external contributor #357

loicmathieu opened this issue Aug 14, 2024 · 0 comments
Labels
kind/cooldown Great candidate for the cooldown period

Comments

@loicmathieu
Copy link
Member

Issue description

Tests didn't pass for external contributor because Rockset tests needs and API Key which is not available out of the Kestra organization.

These tests should only be run if the ROCKSET_APIKEY is set.
An attempt has been done using @EnabledIfEnvironmentVariable(named = "ROCKSET_APIKEY", matches = ".*") but it didn't work.
@loicmathieu loicmathieu added the kind/cooldown Great candidate for the cooldown period label Aug 14, 2024
@kestrabot kestrabot bot added this to Issues Aug 14, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cooldown Great candidate for the cooldown period
Projects
Issues
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loicmathieu