Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cosmetic] Kestra email format could use some cleanup #163

Closed
johnsturgeon opened this issue Apr 11, 2024 · 11 comments
Closed

[cosmetic] Kestra email format could use some cleanup #163

johnsturgeon opened this issue Apr 11, 2024 · 11 comments
Assignees
Labels
area/frontend Needs frontend code changes area/plugin Plugin-related issue or feature request bug Something isn't working good first issue Great issue for new contributors

Comments

@johnsturgeon
Copy link

Describe the issue

I set up an email alert and there are a couple issues:

  1. the image in the resulting email is a bit blurry and misshapen
  2. the backticks on the task indicate that it wants to be rendered as 'code' but it isn't
image

Environment

  • Kestra Version: 0.16.0
  • Operating System (OS/Docker/Kubernetes): Docker
  • Java Version (if you don't run kestra in Docker):
@johnsturgeon johnsturgeon added the bug Something isn't working label Apr 11, 2024
@anna-geller anna-geller added area/backend Needs backend code changes area/plugin Plugin-related issue or feature request area/frontend Needs frontend code changes and removed area/backend Needs backend code changes labels Aug 15, 2024
@sampath24-ss
Copy link
Contributor

sampath24-ss commented Sep 29, 2024

Is anyone working on this issue?

@tchiotludo tchiotludo added the good first issue Great issue for new contributors label Oct 1, 2024
@Ben8t
Copy link
Member

Ben8t commented Oct 1, 2024

@sampath24-ss no, up to you to provide a PR. We'll assign to another developer otherwise in the following days

@sampath24-ss
Copy link
Contributor

Hi @Ben8t,

Thank you for the clarification! Before I proceed with the PR, could you kindly point me to the relevant file(s) or folder where the email rendering code is located? Specifically, I’m looking into the issue.

I appreciate your guidance!

@Ben8t Ben8t transferred this issue from kestra-io/kestra Oct 2, 2024
@Ben8t
Copy link
Member

Ben8t commented Oct 2, 2024

@sampath24-ss
Transfered to proper repository.

I think you can find the HTML template here, and how it is sent here

@MilosPaunovic
Copy link
Member

@Ben8t Maybe it would be a good idea to create an issue on OSS repo with the list of all email designs that need improving and with designs for it, maybe someone from the community could work on it as it is pretty simple task, but will help us greatly.

https://github.com/kestra-io/kestra-ee/issues/1843

@sampath24-ss
Copy link
Contributor

I've identified the issue and made the necessary changes. Unfortunately, I'm unable to run the project locally due to an issue with my machine, so I haven't been able to submit the PR yet. Just wanted to keep you updated. Thank you!

@sampath24-ss
Copy link
Contributor

Hi,
I raised a PR.

@Ben8t
Copy link
Member

Ben8t commented Oct 23, 2024

Thanks @sampath24-ss , can you linked it here in comment please :) ?

@MilosPaunovic
Copy link
Member

#174

@MilosPaunovic
Copy link
Member

Closed via #174.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Issues Oct 25, 2024
@sampath24-ss
Copy link
Contributor

Thanks for the support @Ben8t & @MilosPaunovic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes area/plugin Plugin-related issue or feature request bug Something isn't working good first issue Great issue for new contributors
Projects
Status: Done
Development

No branches or pull requests

6 participants