[Login] Show password in login/sign up form

[cavasinf]

One of our clients has requested the ability to see their password while typing during login.
We can implement this on our side, but I was considering adding it directly into the template.

Looking at the Tabler demo (https://preview.tabler.io/sign-in.html), there is an icon to toggle password visibility, but no JS is attached to it.

We could do the same a their, but include a simple JS embedded in the page (avoiding the need to build a separate script).

We could make this feature configurable through the TableBundle by adding a parameter like "login_show_password", defaulting to true.
This would allow flexibility if someone wants to disable the feature in the future.

WDYT @kevinpapst ?

[kevinpapst]

I thought about it as well in the past, but was too lazy to add it, as nobody really asked for it.

I would really like to start using the UX components: https://ux.symfony.com/toggle-password
But integrating those is very likely much more work than just adding a simple script.

So as you proposed: if you can add it with a feature toggle, I don't mind having that extra functionality in the bundle.

[cavasinf]

I’ve checked out the UX component, and in this case, we’d need to use a form builder to properly "render" the form. While it’s possible to manually replicate what the builder does, I don’t think it’s the best approach in terms of maintainability.

So as you proposed: if you can add it with a feature toggle, I don't mind having that extra functionality in the bundle.

I agree. A simple script to toggle the eye icon and switch the input type between password and text should do the job.