[Layout] Too many "forced" content for inner .page-body

[cavasinf]

Hey,
We’re currently a bit stuck with how the layout-xxx.html.twig file define the base 'structure' of the page.

Objective

The goal is to create a dashboard page with multiple rows and columns of with the same height.

Current state

Currently, the base template forces this HTML structure:

<div class="row row-cards">          
   <section id="" class="content">
       [...]
   </section>
</div>

TablerBundle/templates/layout-vertical.html.twig

Lines 120 to 128 in 39b5e29

	<div class="{{ ''|tabler_container }}">
	<div class="row row-cards">
	{% block page_content_before %}{% endblock %}
	<section id="{% block page_content_id %}{% endblock %}" class="{% block page_content_class %}content{% endblock %}">
	{% block page_content_start %}{{ include('@Tabler/includes/flash_messages.html.twig') }}{% endblock %}
	{% block page_content %}{% endblock %}
	{% block page_content_end %}{% endblock %}
	</section>

Render

Current render

Here's what we have currently:

Desired render:

To achieve this, we need to apply the .row-deck class directly after the top-level .container class, like this:
But we want the .row-deck in the top div + remove the section part.

The whole HTML wanted:

Question/Solution

1. Is there specific reason for having the section block + default row row-cards classes?
2. It may be a relic of admin-lte bundle?

It might be more flexible if this part of the structure was left for the developers to define, rather than enforced by the top-level template.

References with differents classes just after the .container div:
https://preview.tabler.io/
https://preview.tabler.io/activity.html
https://preview.tabler.io/photogrid.html

[kevinpapst]

This was in your initial commit already:
2584dc1#diff-ad9fb94d48b0a156f12a7c3972ef9db886e2eb46f6626bafb146cd53d7d77c69R119

Who knows which feature accidentally work due to this class being existent right now.
Changing would be quite a BC break.

Anyway, a dashboard with same height widgets works perfectly fine for me with that HTML:

You can simply add a second div with the wanted CSS classes and everything works fine.

[cavasinf]

This was in your initial commit already

Yes, I was looking for when/why we do that, it was there from the beginning:
657ea71#diff-77f98db4bbf74ae14cad716cd52d662106d4ea5a78039716a76307c9745b7be9R112-R114

Who knows which feature accidentally work due to this class being existent right now.
Changing would be quite a BC break.

Yes, it could, testing in the table preview, there is no big impact:

1. The .content class does nothing
2. .row .row-cards add the same margin as .page-body.

• The only impact is if you have a js/css selector targeting this.
• Starting a page directly with some .col without .row (because we add it in the base template)