-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is "--cap-add=NET_ADMIN" really needed? #8
Comments
All that is needed is --cap-add=NET_ADMIN, not --device, nor --privileged. I forget the exact reason why --cap-add=NET_ADMIN was needed, but if you try running the container without that, you will notice certain failures (like the ZeroTier token being inaccessible). |
I gave this one another go and it turns out you can tell zerotier to not drop privileges and ignore these sort of errors with the |
@fakuivan thanks for your feedback. |
I was able to get it to work without https://gist.github.com/mdPlusPlus/0f6285c6402aa4aff4aa4a9e5dfc38c0 |
That's great! Do you mind if I possibly use your Docker file in the next build? |
Feel free to do so. |
Great - thanks. I'll keep those points in mind. |
The answer to the subject of this thread is - not any more. Thanks to clues from @mdPlusPlus, the requirement for --cap-add=NET_ADMIN and the clash with Ubuntu UID/GIDs have been circumvented. |
Try latest version here: https://hub.docker.com/r/keynetworks/ztncui |
The documentation for networks controller suggests that since these don't need to join networks, networking administration capabilities are not necessary.
https://github.com/zerotier/ZeroTierOne/tree/master/controller#dockerizing-controllers
Is this true? If so the setup instructions could be updated to follow the principle of least privilege.
The text was updated successfully, but these errors were encountered: