Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why no return error instead log.Fatal? #13

Open
jpascal opened this issue Dec 17, 2021 · 1 comment
Open

Why no return error instead log.Fatal? #13

jpascal opened this issue Dec 17, 2021 · 1 comment

Comments

@jpascal
Copy link

jpascal commented Dec 17, 2021

https://github.com/status-im/keycard-go/blob/b0e0482ba91df26220d05a1901ba3acd6c36d9e3/hexutils/hexutils.go#L17

@gravityblast
Copy link
Collaborator

good catch @jpascal thank you! yes that need to be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants