Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor KeymanHosts #13

Open
mcdurdin opened this issue Feb 9, 2024 · 4 comments
Open

chore: refactor KeymanHosts #13

mcdurdin opened this issue Feb 9, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Feb 9, 2024

KeymanHosts is currently overly complex. However there are a number of challenges around determining which URLs to be using by various parts of the sites -- for example handling overrides for development (as we may not want to be running e.g. api.keyman.com locally).

  1. Use a table-based structure rather than constructing URLs, so that we have explicit references to each tier's possible URLs.
  2. Allow for overrides on DEVELOPMENT tier from a localenv.php? file
  3. Use the same table to generate javascript constants for scripts -- and always use the constants and don't guess
  4. Ensure TIER_TEST overrides.
@mcdurdin mcdurdin added the chore label Feb 9, 2024
@mcdurdin mcdurdin added this to the 18.0 milestone Feb 9, 2024
@mcdurdin
Copy link
Member Author

Also, refactor environment getenv() calls into module so we have a single global KeymanSiteEnvironment class

@mcdurdin
Copy link
Member Author

Future: let users choose which sites they want to host locally, and munge internal links accordingly

@darcywong00
Copy link
Contributor

Future: let users choose which sites they want to host locally, and munge internal links accordingly

See impact to https://github.com/keymanapp/website-local-proxy

@mcdurdin mcdurdin modified the milestones: 18.0, A18S2 Apr 29, 2024
@mcdurdin mcdurdin modified the milestones: A18S2, A18S3, A18S8 May 24, 2024
@darcywong00 darcywong00 modified the milestones: A18S8, A18S9 Aug 17, 2024
@darcywong00 darcywong00 modified the milestones: A18S9, A18S10 Aug 31, 2024
@darcywong00 darcywong00 modified the milestones: A18S10, A18S11 Sep 14, 2024
darcywong00 pushed a commit that referenced this issue Sep 18, 2024
@darcywong00 darcywong00 modified the milestones: A18S11, A18S12 Sep 28, 2024
@darcywong00 darcywong00 modified the milestones: A18S12, A18S13 Oct 11, 2024
@darcywong00 darcywong00 modified the milestones: A18S13, A18S14 Oct 26, 2024
@darcywong00
Copy link
Contributor

From A18S14 sprint plan, we'll defer refactoring till 19.0

@darcywong00 darcywong00 modified the milestones: A18S14, 19.0 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants