-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor KeymanHosts #13
Comments
Also, refactor environment getenv() calls into module so we have a single global KeymanSiteEnvironment class |
Future: let users choose which sites they want to host locally, and munge internal links accordingly |
See impact to https://github.com/keymanapp/website-local-proxy |
From A18S14 sprint plan, we'll defer refactoring till 19.0 |
KeymanHosts is currently overly complex. However there are a number of challenges around determining which URLs to be using by various parts of the sites -- for example handling overrides for development (as we may not want to be running e.g. api.keyman.com locally).
The text was updated successfully, but these errors were encountered: