Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap coordinates + Hold down seems to start on a delay compared to without hold down #1408

Open
2 tasks
sudomain opened this issue Jan 22, 2025 · 0 comments
Open
2 tasks
Assignees
Labels
bug Something isn't working needs triage

Comments

@sudomain
Copy link

sudomain commented Jan 22, 2025

Developer TODO (don't remove)

  • write tests. put issue number in comment
  • update documentation

Discord message link/email recipient

Describe the bug

Two closely related bugs when using the Tap Coordinates action with a "Hold down until trigger is released" option:

  1. The tap seems to start on a delay compared to with out the Hold down option.
  2. If the user releases the trigger quick enough (~ <300ms), no tap happens at all.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Key Map with Tap Coordinates and Hold down until trigger is release
  2. Observe no tapping occuring at all if trigger is released quick enough.

Upload a backup of your keymaps. Follow the guide here

tap_hold_down_bug_key_maps_20250122-124628.zip

Expected behavior
The tap should begin immediately upon trigger, as it does when "Hold down" option is not used. If "Hold down" is used the trigger button is pressed and released in a short amount of time, atleast 1 tap event should occur.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Pixel 2
  • Android version: Android 11

Additional context
I'm developing a Morse code related app that I have tuned to 300ms. That's where I got the 300ms duration from. I was able to produce the problem in other apps too, so I know it's not just my app.
I was able to workaround this by making 2 keymaps:

  1. One with a tap coordinates action without the hold down option
  2. One with a swipe coordinates action that has a 350ms swipe duration. The 350ms is hard coded though
@sudomain sudomain added bug Something isn't working needs triage labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

No branches or pull requests

2 participants