Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨D3B-586 sample relationship #686

Merged
merged 6 commits into from
May 31, 2024
Merged

✨D3B-586 sample relationship #686

merged 6 commits into from
May 31, 2024

Conversation

chris-s-friedman
Copy link
Contributor

No description provided.

@chris-s-friedman chris-s-friedman force-pushed the D3B-586_sample_relationship branch from 1d31b9d to 13e398f Compare May 30, 2024 20:35
@chris-s-friedman chris-s-friedman marked this pull request as ready for review May 30, 2024 20:37
@chris-s-friedman chris-s-friedman requested a review from a team as a code owner May 30, 2024 20:37
znatty22
znatty22 reviewed May 31, 2024
View reviewed changes
Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But I think we need to modify the tests to include both sample and sample relationship. I forgot to make this comment on the sample PR

@chris-s-friedman
✅ Add sample test
b87d2ac 
🚨 Fix linting errors in tests
@chris-s-friedman chris-s-friedman force-pushed the D3B-586_sample_relationship branch from 36703c7 to b87d2ac Compare May 31, 2024 16:16
@chris-s-friedman chris-s-friedman merged commit 7cb601c into master May 31, 2024
6 checks passed
@chris-s-friedman chris-s-friedman deleted the D3B-586_sample_relationship branch May 31, 2024 16:39
chris-s-friedman added a commit that referenced this pull request May 31, 2024
@chris-s-friedman
🏷️ Release 1.21.0
acfa5f3 
## Release 1.21.0

### Summary

- Emojis: ✨ x2, ? x2
- Categories: Additions x2, Other Changes x2

### New features and changes

- [#686](#686) - ✨ D3B-586 sample relationship - [7cb601c](7cb601c) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#683](#683) - ✨ Add Sample Concept - [026ed61](026ed61) by [chris-s-friedman](https://github.com/chris-s-friedman)
- [#684](#684) -  🔧 add ucsf center - [469d097](469d097) by [HuangXiaoyan0106](https://github.com/HuangXiaoyan0106)
- [#680](#680) -  📝 add Variantyx sequencer - [8ccf9ec](8ccf9ec) by [HuangXiaoyan0106](https://github.com/HuangXiaoyan0106)
@chris-s-friedman chris-s-friedman mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znatty22 znatty22 znatty22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-s-friedman @znatty22